search

w3c / mediacapture-output

API to manage the rendering of audio on any audio output device
https://w3c.github.io/mediacapture-output/
Other
25 stars 25 forks source link

Should setSinkId be functional in SecureContext only? #78

Closed jan-ivar closed 5 years ago

jan-ivar commented 6 years ago

Following on https://github.com/w3c/webrtc-pc/issues/1945, would it make sense to make setSinkId [SecureContext]? I.e.

console.log("setSinkId" in document.createElement('video')); // false in http

We're looking for guidance on implementing it in Firefox.

Currently, in Chrome this method exists in http, but is pretty much useless (SecurityError).

As to the read-only sinkId attribute, we could leave it ("") or make it SecureContext as well (undefined). With no way to affect the attribute, it serves little purpose.

guidou commented 6 years ago

Making both [SecureContext] sgtm

cynthia commented 6 years ago

@alvestrand @dontcallmedom was this by any chance touched on during TPAC? If so, would love to see what the outcome of this was!

jan-ivar commented 6 years ago

@cynthia Yes, from minutes and recollection, both setSinkId and sinkId to be SecureContext only.

jan-ivar commented 6 years ago

Has PR.

cynthia commented 5 years ago

Since the PR has landed, would it make sense to close this?