search

w3c / mediacapture-record

MediaStream Recording
https://w3c.github.io/mediacapture-record/
Other
104 stars 21 forks source link

Add replaceTrack method to MediaRecorder. #187

Closed jan-ivar closed 1 year ago

jan-ivar commented 4 years ago

Alternative fix for https://github.com/w3c/mediacapture-record/issues/167.

Preview | Diff

jan-ivar commented 4 years ago

Based on https://github.com/w3c/mediacapture-record/pull/186#issuecomment-531421759 and as described in slide. Also fixed up isolation properties to be per track.

henbos commented 4 years ago

Promise to add a promise

henbos commented 4 years ago

Promise me no promises?

guest271314 commented 4 years ago

@jan-ivar @henbos Reviewing the TPAC minutes could not locate mention of replaceStream() or replaceTrack(). Were the PRs in this repository for the proposals brought up and discussed formally or informally? If so, what were the conclusion reached?

jan-ivar commented 4 years ago

It was discussed here. I felt there was support for progress, though no final consensus as I recall.

guest271314 commented 4 years ago

@jan-ivar What does that ultimately mean as a practical matter?

jan-ivar commented 4 years ago

@Pehrsons PTAL. The concern raised at TPAC was replacing multiple tracks in concert, and whether returning a promise might simplify knowing when it is safe to stop all replaced tracks.

Here's my attempt. Note that MediaRecorder is a different beast from e.g. RTCPeerConnection when it comes to state. Changes are often synchronously observable, and asynchronous operations are not serialized (no operations chain).

ParfectShot commented 2 years ago

any update on this MR ?

alvestrand commented 1 year ago

Seems to have no developer interest in implementation, so closing because of lack of interest.