Update demo - Githubissues

w3c / mediacapture-region

This document introduces an API for cropping a video track derived from display-capture of the current tab.

http://w3c.github.io/mediacapture-region/

Other

40 stars 10 forks source link

Update demo #66

Closed beaufortfrancois closed 2 years ago

beaufortfrancois commented 2 years ago

This PR cleans up the demo used in this repository with latest spec changes:

Use cropTarget instead of cropID everywhere
Use null instead of the empty string "" when uncropping

Nits:

Remove superfluous JSON.stringify() when postMessage()
Moves right.html <video> element at the top to avoid scrolling every time user wants to change sources.

@eladalon1983 Please have a look

eladalon1983 commented 2 years ago

Thew changes here are mostly s/cropID/CropTarget, which is a simple follow-up on previously merged PRs changing the spec. I think this is clearly editorial.

beaufortfrancois commented 2 years ago

I just noticed this PR has addressed part of https://github.com/w3c/mediacapture-region/issues/58