Closed kakukogou closed 8 years ago
LGTM.
One case where using a constructor for ChannelPixelLayout
might come handy would be to provide some sort of error handling for invalid input per channel. However, I think we're better off doing that on the ImageFormatPixelLayout
level instead.
@rocallahan suggested that rename the
ImageFormatPixelLayout
toImagePixelLayout
because the original one is too redundant.@smaug---- suggested using WebIDL dictionary for
ChannelPixelLayout
and then theImage(Format)PixelLayout
becomes justsequence<ChannelPixelLayout>
. (maybe using atypedef
)