search

w3c / mediacapture-worker

MediaStream with worker
Other
9 stars 12 forks source link

Fix #30: Decouple VideoProcessor/Monitor from Workers #53

Closed anssiko closed 8 years ago

anssiko commented 8 years ago

A quick rewrite based on the suggestions in #30. The idea is to test how this approach resonates with people, solicit further feedback, and if there's agreement polish further. Beware, has rough edges.

rawgit.com HTML preview with changes

anssiko commented 8 years ago

@ChiahungTai @kakukogou PTAL.

If this looks good, we could land this first and then you could rebase #53 and #54.

kakukogou commented 8 years ago

LGTM with the comments. Let's wait for @ChiahungTai 's review, he might have some feedbacks from implementation.

anssiko commented 8 years ago

@kakukogou Thanks for the comments! I'll fix them all at once after getting @ChiahungTai feedback as well.

ChiahungTai commented 8 years ago

I hope I can review this patch next week. Busy at fixing regression and test case fail in my re-factoring bug. :(

anssiko commented 8 years ago

@ChiahungTai @kakukogou thanks for the review!