w3c / musicxml

MusicXML specification
518 stars 57 forks source link

Add complete SMuFL guitar range #100

Closed mdgood closed 7 years ago

mdgood commented 9 years ago

MusicXML could complete its support for the SMuFL guitar range U+E830–U+E84F for better interoperability between applications. The range is documented at http://w3c.github.io/smufl/gitbook/tables/guitar.html.

MusicXML 3.0 already supports the string symbols in this range. Completing the range would involve adding:

This issue arose while analyzing MusicXML 3.0 for SMuFL support in preparation for the 2015 MusicXML community meeting at Musikmesse. Requests for some of these symbols have also been made by MusicXML developers in private emails.

asieralkortaformazioa commented 8 years ago

Regarding the tapping glyphs, it's cool to have those new symbols, but it could be even more useful if the symbols added information about which finger is used in the tapping.

For example, instead of the "T" of tapping, "I" could be used to represent that the tapping should be done using the index finger, "M" for middle, "R" for ring, "L" for little finger and "T" for the thumb.

Another coding system could be used to display this information, but I think including it could be useful.

mdgood commented 7 years ago

My current thoughts are to

Some of the other glyphs have already been handled by smufl attributes on other elements - for instance, guitarStrumUp and guitarStrumDown have been handled by issue #79 when we added the smufl attribute to the <arrow> element. The remaining glyphs could be handled by using the <other-technical> element with the appropriate smufl attribute.

However, I am not very knowledgeable about guitar notation. It would be great if some of our more guitar-knowledgeable group members could review this and suggest improvements if needed. @adrianholovaty, what do you think about this proposal?

Thanks for any assistance on this issue!

adrianholovaty commented 7 years ago

@mdgood These proposals all sound reasonable to me. :-)

mdgood commented 7 years ago

Thanks @adrianholovaty! Pull request #201 addresses this issue. Might you have a chance to review the pull request?

adrianholovaty commented 7 years ago

@mdgood Done! Looks good to me.

mdgood commented 7 years ago

Thanks for the review Adrian!

snakebyte69 commented 5 years ago

The "with-bar" element also needs "warble" to be added to it.

Warble is a technique where you quickly strike the whammy bar to make it vibrate quickly, this produces a very distinct type of vibrato. It's a very common technique in Heavy Metal used by players like Jason Becker, Steve Vai, John Petrucci and many others.

GualtieroChiapello commented 4 years ago

On the final page of the score "Pictures at an Exhibition" (Mussorgsky - Mar.1981) of the arrangement by the classical guitar master Kazuhito Yamashita there are elements of notation with their meaning: strangely they have not yet been considered.

Example: yamashita