w3c / navigation-timing

Navigation Timing
https://w3c.github.io/navigation-timing/
Other
116 stars 30 forks source link

Update diagram to make unload parallel #191

Closed noamr closed 1 year ago

noamr commented 1 year ago

This was erroneously reverted by an unrelated diagram change.

noamr commented 1 year ago

LGTM.

Do you know if there are any WPT to confirm all browsers act like this?

Since unload is about to be deprecated, I wouldn't want to spend too much cycles on this.

Also, on an unrelated note I wonder if we should include firstInterimResponseStart while we're at it.

Done

tunetheweb commented 1 year ago

I think you need to extend the "Resource Timing" dotted line to include the Response box? Previously this was only half of the Response box but not sure why (shouldn't it be all the Response box). Also seems to be a gap before the title:

image

noamr commented 1 year ago

I think you need to extend the "Resource Timing" dotted line to include the Response box? Previously this was only half of the Response box but not sure why (shouldn't it be all the Response box). Also seems to be a gap before the title:

image

Done

tunetheweb commented 1 year ago

Thanks, but I still see the space to the left of the title of that dotted section (I'm getting real picky now!):

image
noamr commented 1 year ago

Thanks, but I still see the space to the left of the title of that dotted section (I'm getting real picky now!):

image

How is it now?

tunetheweb commented 1 year ago

OK now it definitely LGTM! Thanks for addressing my concerns!

noamr commented 1 year ago

OK now it definitely LGTM! Thanks for addressing my concerns!

Thanks for helping make this better!