search

w3c / navigation-timing

Navigation Timing
https://w3c.github.io/navigation-timing/
Other
116 stars 30 forks source link

Fix ReSpec issues #80

Closed marcoscaceres closed 6 years ago

marcoscaceres commented 6 years ago

closes #77

Preview | Diff

marcoscaceres commented 6 years ago

This fixes all the ReSpec issues, but only partially fixes some of the problems in the spec with regards to markup.

marcoscaceres commented 6 years ago

I also took the liberty of fixing the main example... console.table() is much better there, and shows off .toJSON() too.

siusin commented 6 years ago

@marcoscaceres Thanks for getting this done \o/

Everything looks good, except for a few broken links.

marcoscaceres commented 6 years ago

Lots of broken links still.

Should we do those as a new PR?

marcoscaceres commented 6 years ago

Did couple more... that's unfortunately all the time I have to spend on this, as I'm working on other projects. However, all the broken links are easy to fix from here.... but there are a few things that don't exist in HTML anymore that need to be updated in this spec (e.g., "HTTP response codes equivalence").

siusin commented 6 years ago

Thanks @marcoscaceres ! I'll try to fix the other broken links, as well as the ReSpec issues in the RT spec, please leave them to me :)

marcoscaceres commented 6 years ago

Thanks @siusin! If you have any ReSpec questions just email me or ping me on IRC "marcosc". And, I'm always more than happy to review stuff.