w3c / orientation-sensor

Orientation Sensor
https://www.w3.org/TR/orientation-sensor/
Other
12 stars 21 forks source link

Define GeomagneticOrientationSensor interface #15

Open alexshalamov opened 7 years ago

alexshalamov commented 7 years ago

The OrientationSensor interface could define methods and internal slots (quaternion), while subclasses can explicitly define model and what kind of low-level sensors are used for fusion, e.g.:

pozdnyakov commented 7 years ago

SGTM

kenchris commented 7 years ago

Can we actually implement this. I mean on Android the above "AbsoluteOrientationSensor" might use different impl if magnetometer isnt available. Is it possible for us to detect that?

kenchris commented 7 years ago

Apart from that, I think this is fine.

anssiko commented 7 years ago

@kenchris, it seems your explainer doc does identify high value use cases for all three:

https://w3c.github.io/motion-sensors/#orientation https://w3c.github.io/motion-sensors/#geomagnetic-orientation https://w3c.github.io/motion-sensors/#relative-orientation

That said, the use case for Relative Orientation Sensor ("This avoids the delay which low and high pass filters introduce.") could be more explicit.

alexshalamov commented 7 years ago

Can we actually implement this. I mean on Android the above "AbsoluteOrientationSensor" might use different impl if magnetometer isnt available. Is it possible for us to detect that?

@kenchris Yes, we can always check what low level sensors are supported by the platform.

pozdnyakov commented 7 years ago

@kenchris in that perspective (and looks like we all agreed :) ) do you think it's worth renaming Orientation Sensor into Absolute Orientation Sensor in https://w3c.github.io/motion-sensors/#orientation ?

kenchris commented 7 years ago

If we can do that without instantiating them, awesome, then let's go with this :-)

kenchris commented 7 years ago

@pozdnyakov yes that makes sense.

pozdnyakov commented 7 years ago

If we can do that without instantiating them, awesome, then let's go with this :-)

we can :D

alexshalamov commented 7 years ago

Reopening the issue, as it should be closed only when last GeomagneticOrientationSensor is specified.

anssiko commented 6 years ago

Marked as "Level 2" per WG call decision.