search

w3c / ortc

ORTC Community Group specification repository (see W3C WebRTC for official standards track)
http://www.w3.org/community/ortc/
122 stars 42 forks source link

QUIC: Add buffering support to RTCQuicStream #795

Closed aboba closed 6 years ago

aboba commented 7 years ago

Adds waitForReadable, waitForWritable and setTargetReadBufferedAmount methods, as well as readBufferedAmount, maxReadBufferedAmount, writeBufferedAmount, maxWriteBufferedAmount and targetReadBufferedAmount attributes.

Completes fix for Issue https://github.com/w3c/ortc/issues/584

The specification with the PR merged can be viewed here: http://internaut.com:8080/~baboba/ortc/github/ortc-master/

aboba commented 7 years ago

@pthatcher Can you review?

lgrahl commented 6 years ago

I would like to continue contributing to the ORTC API but this is starting to bother me: Please respond to my suggestions and questions when I take part in a discussion. Or, if my input does not matter for the decision-making process whether a PR can be merged as is or should be changed, then by all means let me know.

robin-raymond commented 6 years ago

@lgrahl No, this wasn't to say anyone's voice was unimportant or that the API is settled. The PR was getting so large with so many changes, and threads within individual line PR line commits. We decided to merge to be able to a) get better visibility to the changes and b) continue to refine from this point. This doesn't mean the API is settled but it allows us to refine from a delta point rather than leaving a rather large PR outstanding. In other words, it's better to have "something" now as a place holder and continue to refine than leave it a big unwielding and non-understandable mess. We know getting this low level base API right is important.

lgrahl commented 6 years ago

@robin-raymond Okay, thanks for the clarification. :+1: Please ping me once the discussion is reopened in another issue.

aboba commented 6 years ago

@lgrahl @robin-raymond Peter Thatcher presented the QUIC API at the WebRTC WG meeting at W3C TPAC on November 7. I have filed Issue https://github.com/w3c/ortc/issues/796 based on that discussion. Please file additional issues based on your review.