Feat: allow show() to take optional detailsPromise

w3c / payment-request

Payment Request API

https://www.w3.org/TR/payment-request/

Other

488 stars 135 forks source link

Feat: allow show() to take optional detailsPromise #672

Closed marcoscaceres closed 6 years ago

marcoscaceres commented 6 years ago

closes #645

[x] tests - Part 1 - rejects, Part 2 - resolves
[x] MDN Docs

Implementer issues filed:

[x] Safari
[x] Chrome
[x] Edge - ack from @adrianba
[x] Firefox

Preview | Diff

marcoscaceres commented 6 years ago

Thanks again for the review, @domenic!

marcoscaceres commented 6 years ago

Part 1 of tests https://github.com/w3c/web-platform-tests/pull/9617

marcoscaceres commented 6 years ago

Tests are complete, awaiting review on: Part 1 - rejects.

@aestes, not sure if it helps you much, but I added ApplePay as a payment method identifier to the tests. Let me know if there is anything I can do in web platform tests to make it easier to test in WebKit/Safari.

marcoscaceres commented 6 years ago

I've added MDN documentation for this.

marcoscaceres commented 6 years ago

@ianbjacobs, could you kindly please request the specification be republished.

ianbjacobs commented 6 years ago

@marcoscaceres, request sent today for 1 March publication.