search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
489 stars 135 forks source link

Add regionCode attribute #690

Closed marcoscaceres closed 6 years ago

marcoscaceres commented 6 years ago

closes w3c/contact-picker#65

The following tasks have been completed:

Implementation commitment:

Preview | Diff

marcoscaceres commented 6 years ago

Added test and indicated commitment to support this in Gecko.

Anyone else going to support this (PaymentAddress.regionCode): @aestes, @adrianba, @zkoch, @adrianba? If so, please give a tick above.

If "maybe later", also useful, in case this needs to be also marked at risk.

marcoscaceres commented 6 years ago

Added MDN Page also now part of the PaymentAddress definition.

rsolomakhin commented 6 years ago

@sebsg: I saw you working on bringing ISO region codes to libaddressinput and Chrome. Do you have a tracking bug for exposing it in PaymentRequest that we can link here?

sebsg commented 6 years ago

I created https://bugs.chromium.org/p/chromium/issues/detail?id=817960 to track the work

marcoscaceres commented 6 years ago

@rsolomakhin, when you can, could you please let me know the bug number for Chrome for adding the attribute?

rsolomakhin commented 6 years ago

@marcoscaceres: We will use https://crbug.com/817960 for adding the attribute as well.

marcoscaceres commented 6 years ago

Can definitely just return everything after “-“, as we have the country. A 3166-2 code is always country-subregion. However, the codes are easier to look up as complete codes so my personal preference would be to not chop them up. Happy to hear other opinions.

marcoscaceres commented 6 years ago

@mnoorenberghe ok, just subdivision part is returned now. Check it!

Rules are:

Need to redo the tests and MDN docs, but would appreciate review in meantime.

marcoscaceres commented 6 years ago

@domenic, this spec text should hopefully now be good to go 🤞

marcoscaceres commented 6 years ago

Added new tests, updated MDN docs.

marcoscaceres commented 6 years ago

@ianbjacobs, could you kindly please republish the specification on TR? Thanks in advance!

marcoscaceres commented 6 years ago

@domenic thanks again for your time and the great feedback! ✨

ianbjacobs commented 6 years ago

@marcoscaceres, aiming for 17 May publication. Thanks all!

Update: 22 May due to moratorium.