search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
488 stars 135 forks source link

Fix a small bug in `abort`'s error handling. #733

Closed mrbkap closed 6 years ago

mrbkap commented 6 years ago

Because PaymentRequest.abort returns a Promise<void>, it shouldn't be specified to throw exceptions. Instead, it should return rejected promises.

Somewhat complicating this is that Safari does throw an exception (even though Firefox and Blink do not). This has an impact on web developers as an eager exception will stop their scripts and a rejected promise will not.

marcoscaceres commented 6 years ago

Marked as non substantive for IPR from ash-nazg.

marcoscaceres commented 6 years ago

Thanks, @mrbkap! Probably a few of those we missed... too much async/await corrupting our editorial practices :)