Rename AddressErrorFields -> AddressErrors

w3c / payment-request

Payment Request API

https://www.w3.org/TR/payment-request/

Other

489 stars 135 forks source link

Rename AddressErrorFields -> AddressErrors #755

Closed marcoscaceres closed 6 years ago

marcoscaceres commented 6 years ago

The following tasks have been completed:

[x] Confirmed there are no ReSpec errors/warnings.
[x] Added Web platform tests
[ ] added MDN Docs (link)
[ ] added MDN compat data

Implementation commitment:

[x] Safari - already implemented as AddressErrors.
[ ] Chrome (link to issue)
[X] Firefox - already implemented.
[ ] Edge (public signal)

Impact on Payment Handler spec?

Preview | Diff

marcoscaceres commented 6 years ago

@domenic, just a rename here. We already implemented this in Gecko as AddressErrors a while back, so want to get this in before any other implementer starts on this (and also saves me a few weeks of back and forth on code review, etc. on the Gecko side).

marcoscaceres commented 6 years ago

This is editorial, and not detectable, so really Gecko could call this whatever it wants...

Yeah, true that... but it has impact when searching for things in c++ across engines, etc.