search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
489 stars 135 forks source link

Remove PaymentAddress' languageCode #765

Closed marcoscaceres closed 5 years ago

marcoscaceres commented 6 years ago

closes #608

The following tasks have been completed:

Implementation commitment:

Impact on Payment Handler spec? None

Preview | Diff

marcoscaceres commented 6 years ago

Updated MDN, and sent a PR to WTP to remove languageCode.

marcoscaceres commented 6 years ago

Chairs, we should decide on a timeframe for feedback on this from the community.

1 month CFC?

I'm going to remove from Gecko in the mean time. Can always revert it later if we need it.

rsolomakhin commented 6 years ago

The usage counter will inform our decision to remove the languageCode immediately or after some developer outreach.

marcoscaceres commented 6 years ago

@rsolomakhin

The usage counter will inform our decision to remove the languageCode immediately or after some developer outreach.

Great! Will you be notified automatically once the results are collected? I'll wait for your results before merging.

rsolomakhin commented 6 years ago

Will you be notified automatically once the results are collected?

I wish! I have a calendar reminder to check the data :-)

marcoscaceres commented 6 years ago

I wish! I have a calendar reminder to check the data :-)

Good enough đź‘Ť

marcoscaceres commented 6 years ago

Removed from Firefox.

aestes commented 6 years ago

I've removed it from Safari as well.

adrianhopebailie commented 5 years ago

@marcoscaceres please tag me or @mountainhippo if you need anything from the chairs. Only saw this now.

@ianbjacobs is this covered by process? We never marked this as at risk previously

ianbjacobs commented 5 years ago

Hi all,

I had hoped we would hold off merging until after the CfC. That is why the draft CfC I circulated pointed to the pull request. My expectation was to merge after the CfC.

Ian

marcoscaceres commented 5 years ago

Yep, that’s the plan. It’s actually to wait for @rsolomakhin to gather data from Chrome before we make a final decision.

marcoscaceres commented 5 years ago

Call for Consensus: https://lists.w3.org/Archives/Public/public-payments-wg/2018Sep/0005.html

marcoscaceres commented 5 years ago

@rsolomakhin, how’s that data looking? Any chance we will know by TPAC? We’ve removed this from Firefox and it’s also gone from Safari. Hopefully it’s all good news on the Chrome side.

rsolomakhin commented 5 years ago

Data shows we can remove from Chrome. I've sent out the intent to deprecate.

rsolomakhin commented 5 years ago

So, we will print a deprecation warning in developer console for a couple of months, then will remove it outright.

marcoscaceres commented 5 years ago

Awesome, thanks for confirming and doing the due diligence! Going to merge this then.