w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
489 stars 135 forks source link

Add paymentMethodErrors, payerErrors, to PaymentDetailsUpdate #768

Closed marcoscaceres closed 5 years ago

marcoscaceres commented 6 years ago

The following tasks have been completed:

Implementation commitment:

Optional, Impact on Payment Handler spec?


Preview | Diff

marcoscaceres commented 6 years ago

@romandev, I saw you were helping implementing .retry() on the Chrome side. Is that correct?

marcoscaceres commented 6 years ago

@romandev wrote:

Yep, I'm implementing retry() feature in Chromium under @rsolomakhin's high-quality review.

Excellent to hear! What do you think of the proposed fix here? Make sense from an implementation perspective?

marcoscaceres commented 6 years ago

One question is whether the some error values can be updated via updateWith() on an unrelated event. For example, requestShipping and requestPayerName are all true and merchant calls updateWith() on payer detail change event as follows.

I think it's fine, tbh.

In this case, should we allow shippingAddressErrors to be updated on payer detail change event?

I think we should allow it - just to reduce our (implementation) complexity. It's not different from a developer randomly invalidating their form elements.

marcoscaceres commented 5 years ago

This is implemented in Firefox as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1435161

marcoscaceres commented 5 years ago

@romandev, can I get implementation commitment from the Blink side?

romandev commented 5 years ago

@marcoscaceres Sure. I'm working on it.

marcoscaceres commented 5 years ago

@romandev awesome to hear. When you can, could you drop add a tracking bug? 🙏

romandev commented 5 years ago

I also filed this in Chromium :) https://bugs.chromium.org/p/chromium/issues/detail?id=884433

marcoscaceres commented 5 years ago

We've implemented this in Firefox. Landing this with @romandev's r+.

aestes commented 5 years ago

We've implemented this in WebKit: https://trac.webkit.org/r236552