w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
489 stars 135 forks source link

Rename `PayerErrorFields` to `PayerErrors` #789

Closed akansha2608 closed 5 years ago

akansha2608 commented 5 years ago

closes #782

The following tasks have been completed:

Implementation commitment:

Optional, Impact on Payment Handler spec?


Preview | Diff

marcoscaceres commented 5 years ago

Thanks @akansha2608. Two little things: please be sure to retain the pull request template, as all tasks listed there need to be completed before we can merge. I've added it back above so we can work through it. Also, please use "@marcoscaceres" not @marcos-travel - as that's just an account I use while traveling.

So, to start, when you open "index.html" from your local file system, can you confirm there are no errors or warnings next to the "ReSpec" button at the top of right of the spec?

Secondly, you need to check that PayerErrorFields doesn't appear on MDN (we might be lucky and it's not yet documented). But please confirm. If it's not documented, then we need to document it.

Lastly, we need to get implementation commitment from various browsers.

@aestes, @romandev or @rsolomakhin, minor bike shedding change? You all ok with this change?

marcoscaceres commented 5 years ago

Marked as non substantive for IPR from ash-nazg.

marcoscaceres commented 5 years ago

Firefox tracking bug https://bugzilla.mozilla.org/show_bug.cgi?id=1495335

romandev commented 5 years ago

Chromium tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=890660

akansha2608 commented 5 years ago

Thanks @akansha2608. Two little things: please be sure to retain the pull request template, as all tasks listed there need to be completed before we can merge. I've added it back above so we can work through it. Also, please use "@marcoscaceres" not @marcos-travel - as that's just an account I use while traveling.

Hi , thanks for the review , i will make sure from next time , its done totally by mistake.

So, to start, when you open "index.html" from your local file system, can you confirm there are no errors or warnings next to the "ReSpec" button at the top of right of the spec?

Hi @marcoscaceres , I checked the index.html on my local system , there is no errors or warnings near ReSpec button . Also attached screenshot for the same :)

Secondly, you need to check that PayerErrorFields doesn't appear on MDN (we might be lucky and it's not yet documented). But please confirm. If it's not documented, then we need to document it.

Yes we are lucky its not documented https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/PayerErrorFields, do we need to create another issue for the same? :smile:

screenshot_2018-10-01 payment request api

marcoscaceres commented 5 years ago

do we need to create another issue for the same?

@akansha2608, no, we generally just do it as part of this issue and then check the box at the top when it's done.

I'm seeing at least one mention of PayerErrorFields here: https://developer.mozilla.org/en-US/search?q=PayerErrorFields&topic=apps&topic=html&topic=css&topic=js&topic=api&topic=canvas&topic=svg&topic=webgl&topic=mobile&topic=webdev&topic=http&topic=webext&topic=standards

Could you kindly please update it?

akansha2608 commented 5 years ago

I'm seeing at least one mention of PayerErrorFields here: https://developer.mozilla.org/en-US/search?q=PayerErrorFields&topic=apps&topic=html&topic=css&topic=js&topic=api&topic=canvas&topic=svg&topic=webgl&topic=mobile&topic=webdev&topic=http&topic=webext&topic=standards

Could you kindly please update it?

Hi @marcoscaceres i updated this.

Can you guide me through first about first about documentation please :) How to do that?

marcoscaceres commented 5 years ago

Can you guide me through first about first about documentation please :) How to do that?

Will follow up on Slack.

marcoscaceres commented 5 years ago

Merging this so it's easier to do the docs

aestes commented 5 years ago

WebKit tracking bug: https://bugs.webkit.org/show_bug.cgi?id=191213