Clarify when the user can abort the payment request algorithm

w3c / payment-request

Payment Request API

https://www.w3.org/TR/payment-request/

Other

489 stars 135 forks source link

Clarify when the user can abort the payment request algorithm #810

Closed marcoscaceres closed 5 years ago

marcoscaceres commented 5 years ago

closes #796

The following tasks have been completed:

[x] Confirmed there are no ReSpec errors/warnings.
[ ] Modified Web platform tests (link)
[ ] Modified MDN Docs (link)

Implementation commitment:

[ ] Safari (link to issue)
[ ] Chrome (link to issue)
[ ] Firefox
[ ] Edge (public signal)

Optional, Impact on Payment Handler spec? None

Preview | Diff

marcoscaceres commented 5 years ago

So, we had in there that there could be a timeout or some other means of aborting. However, I think we were going down the wrong path... I've routed the "timeout" and the user hitting "esc" down the "user aborts the payment request" path instead. I also removed the "[[updating]]" check to allow for this.

marcoscaceres commented 5 years ago

@domenic, if you have time, can you please sanity check this?

marcoscaceres commented 5 years ago

Filed bug about de-dupe abort the update and user aborts. https://github.com/w3c/payment-request/issues/814

marcoscaceres commented 5 years ago

As this makes provisions for an optional UI feature (a "cancel" button or user triggered action, like a hitting "esc"), I'm ok with merging this as is. It doesn't really add any new conformance requirements. It just clarifies behavior that matches what browsers already do.