search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
486 stars 133 forks source link

Move PaymentAddress string defaults to AddressInit #853

Closed marcoscaceres closed 4 years ago

marcoscaceres commented 5 years ago

Right now, we do a lot of "set address.[[slot]] to the empty string" in prose. We should just move all that prose logic to AddressInit by setting each member to default to "" and = [] for any sequence type.

This shouldn't have any impact on developers, as the behavior we get is identical. However, it does significantly simplify implementation (as the binding layer can handle all of the above).

marcoscaceres commented 5 years ago

Setting as 1.1 target. CC @rsolomakhin, @aestes , @danyao, wdty?

rsolomakhin commented 5 years ago

This shouldn't have any impact on developers, ... significantly simplify implementation

Sign me up!

marcoscaceres commented 5 years ago

I’ll put together a PR so you can see the changes. We can go from there.

marcoscaceres commented 5 years ago

Put up https://github.com/w3c/payment-request/pull/852