search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
486 stars 133 forks source link

[[waitForUpdate]] must be set to true always after dispatch. #854

Closed marcoscaceres closed 5 years ago

marcoscaceres commented 5 years ago

Elsewhere, @danyao wrote:

From my reading of the spec, [[waitForUpdate]] is only set to true after updateWith() is called. Am I missing something?

Yes, indeed a small spec bug. Will send a patch.

danyao commented 5 years ago

Hi @marcoscaceres! I noticed that the payer detail change algorithm also fires a PaymentRequestUpdateEvent. But in this case, the algorithm doesn't set [[waitForUpdate]] to true immediately after event dispatching. Should we make it align with the other cases?

marcoscaceres commented 5 years ago

Yeah, well spotted. I'll draft a PR for the spec. We'll need to check if we have a test for that - but it should be easy to test.

On Mar 29, 2019, at 2:56 AM, Danyao Wang notifications@github.com wrote:

Hi @marcoscaceres! I noticed that the payer detail change algorithm also fires a PaymentRequestUpdateEvent. But in this case, the algorithm doesn't set [[waitForUpdate]] to true immediately after event dispatching. Should we make it align with the other cases?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.