fix: set default for optional dictionaries

marcoscaceres commented 4 years ago

The following tasks have been completed:

[x] Confirmed there are no ReSpec errors/warnings.
[X] Modified Web platform tests - IDL changes will be picked up automatically.

Implementation commitment:

[ ] Safari (link to issue)
[ ] Chrome (link to issue)
[X] Firefox
[ ] Edge (public signal)

Optional, impact on Payment Handler spec? none.

@rsolomakhin, @danyao, the underlying IDL change is tracked at: https://bugs.chromium.org/p/chromium/issues/detail?id=984949

@aestes, this change is a result from a change to WebIDL that introduces a default dictionary value of {} for when dictionaries are optional: https://github.com/heycam/webidl/pull/750

I'm not sure who to ping on the WebKit side about updating the binding layer.

Preview | Diff

marcoscaceres commented 4 years ago

@domenic ping - super quick PR.

marcoscaceres commented 4 years ago

I'm going to go ahead and merge this, as it's blocking a release of the spec-generator (this spec is checked by spec-generator to make sure ReSpec is working correctly before release). https://travis-ci.com/w3c/spec-generator

danyao commented 4 years ago

LGTM!

w3c / payment-request

fix: set default for optional dictionaries #874