search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
489 stars 135 forks source link

Payment Method Basic Card spec uses various Payment Request definitions that Payment Request does not yet export #890

Closed janiceshiu closed 4 years ago

janiceshiu commented 4 years ago

The payment method basic card spec has many data-cite attributes that link to various definitions in payment request. However, those definitions are not yet exported to xref. Could we export this to xref so that basic card can use xref for linking? Thanks!

  1. Payment Request Options
  2. Payment Request Creating a Payment Address from user-provided input
  3. Payment Request Payment Method Changed Algorithm
  4. Payment Request serialized method data
  5. Payment Request serialised modifier data
  6. Payment Request Details
  7. Payment Request Payment Details Base Modifiers
  8. Payment Request Payment Details Modifier Total
  9. Payment Request Payment Details Modifier Additional Display Items
janiceshiu commented 4 years ago

updated issue to list all missing exported definitions

danyao commented 4 years ago

Hi @janiceshiu Thanks for the contribution. Are you looking for a review or still working on this patch?

janiceshiu commented 4 years ago

Hi @danyao! I'd first like to check with payment request spec maintainers that those terms are okay to export to be used by other specs. If it is okay, I can submit a PR that adds the relevant data-export="" attributes. If there is a better way to go about this, please let me know. Thanks!

danyao commented 4 years ago

Ah got it. Thanks for the context!

I think it's fine to export the list you proposed.