search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request-1.1/
Other
482 stars 183 forks source link

the user interface's language should not be derived from `the body element` #895

Closed janiceshiu closed 4 years ago

janiceshiu commented 4 years ago

From the payment request spec, https://github.com/w3c/payment-request/blob/fe208dba28724d0a316bf706fbf39cc4414bd8f2/index.html#L1094-L1097 The body element's definition states "The body element of a document is the first of the html element's children that is either a body element or a frameset element, or null if there is no such element."

Thus,

In this PR, @annevk states

I'm not sure I support the use case. Other APIs, e.g., the notification API, have no such defaulting and have explicit support for language annotation. And especially for the frameset case it seems that it's highly likely it might not match the language of the application anyway.

Thus, the user interface's language should not be derived from "the body element". The spec could probably include explicit support for language annotation the way the notification API does it.

cc @marcoscaceres

marcoscaceres commented 4 years ago

Agree, we should drop this requirement as I don't think anyone implements this. It should just be noted that, by default, payment sheet will use the browser's default language.

In future version of the spec, we should add {dir: "", lang: ""} members to either the PaymentDetailsInit or to individual PaymentItems. Not sure yet what the right level of granularity should be. I think we discussed something similar a few years ago... we should do some archeology.

marcoscaceres commented 4 years ago

Dug up:

marcoscaceres commented 4 years ago

Sent PR: https://github.com/w3c/payment-request/pull/896