w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request/
Other
489 stars 135 forks source link

Deprecate allowpaymentrequest attribute #928

Closed marcoscaceres closed 4 years ago

marcoscaceres commented 4 years ago

closes #925

The following tasks have been completed:

Implementation commitment:

Optional, impact on Payment Handler spec? None.

Waiting on: https://github.com/whatwg/html/pull/5915 https://github.com/w3c/webappsec-permissions-policy/pull/402


Preview | Diff

ianbjacobs commented 4 years ago

Looks good (but I am not an implementer).

marcoscaceres commented 4 years ago

(but I am not an implementer).

You are an honorary implementer 😂

marcoscaceres commented 4 years ago

I'm going to migrate the WPTests to use allow="payment", that way we don't lose those existing tests.

marcoscaceres commented 4 years ago

Updated tests at https://github.com/web-platform-tests/wpt/pull/25560

marcoscaceres commented 1 year ago

@stephenmcgruer, seems Chrome night not have gotten updated to match? (the allowpaymentrequest attribute was removed from HTML a few years ago) https://bugs.chromium.org/p/chromium/issues/detail?id=1127988

stephenmcgruer commented 1 year ago

Hey Marcos - yes, we tried to remove allowpaymentrequest previously, but found that usage was too high for a trivial removal. (This is the UseCounter). I admit we then put it aside and failed to come back to it :(, but the next steps for us are to dig into cases where the metric triggers to see if we can identify ways to drive it down. This is tracked in https://crbug.com/1127988