w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request-1.1/
Other
482 stars 183 forks source link

Derive direction from document element too #956

Closed marcoscaceres closed 3 years ago

marcoscaceres commented 3 years ago

Related to, but does not close #327, #946, #948, #951

The following tasks have been completed:

Implementation commitment:

Optional, impact on Payment Handler spec?


Preview | Diff

ianbjacobs commented 3 years ago

Hi @marcoscaceres,

Thanks for starting this. Some thoughts:

1) The phrase "payment sheet" is not used elsewhere in the document. I think we should either define it (e.g., by adding "(called the 'payment sheet')" after "Present a user interface" at the beginning of item 18) or remove it. If we remove it, then the note title could become: "Localization of the user interface to interact with handlers". Then you could just s/payment sheet/user interface/ in the note body.

2) Point 18 says "SHOULD use info provided in content." It's not clear to me that the note needs to say "As such, user agents will generally present the payment sheet using the user agent's default language." That to me suggests that despite the recommendation we just made, nobody is doing it.

What about a Note that says:

"This API relies on inherited localization information. The working group is considering support for fine-grained localization of the user interface and of individual PaymentItems in a future version of this API."

marcoscaceres commented 3 years ago

That to me suggests that despite the recommendation we just made, nobody is doing it.

That's the truth tho :)

Will update based on your suggestions.

ianbjacobs commented 3 years ago

@aphillips, would you mind having a look at this proposal to address the lack of fine-grain localization in V1 of the API? Thank you!