w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request-1.1/
Other
482 stars 183 forks source link

Add internationalization support for human readable labels #971

Closed ianbjacobs closed 2 years ago

ianbjacobs commented 2 years ago

The Internationalization Working Group has raised concerns about lack of Internationalization support for two strings in the specification (see issues #948 and #951).

I agree that the specification should support internationalization.

I believe the following is deployment reality:

Summary: In practice these strings are used almost exclusively used by the Google Pay and Apple Pay native apps.

Other observations:

Given this context, the current pull request seeks a balance:

[Added after posting: if people disagree with the above characterization, please weigh in on that. Thanks!]

I look forward to feedback from @aphillips, @r12a, and the Internationalization Working Group, as well as @marcoscaceres, @stephenmcgruer, @rsolomakhin, and @nickjshearer.

[1] https://www.w3.org/2020/Process-20200915/#candidate-addition

The following tasks have been completed:

Implementation commitment:


Preview | Diff

marcoscaceres commented 2 years ago

Here is a concrete plan:

ianbjacobs commented 2 years ago

@marcoscaceres, quick clarification regarding your plan. Are these steps you recommend after publication of the Rec with this pull request integrated?

marcoscaceres commented 2 years ago

After Rec, as these are additions for a Recommendation.

marcoscaceres commented 2 years ago

I might be persuaded if you can explain your reasoning @marcoscaceres :)

So, we wouldn't merge this until after REC, and we would only merge this if our group's criteria is met: we would fully spec this out, add tests, and get implementation commitment (same as any feature we've added to the spec in the past).

ianbjacobs commented 2 years ago

Based on joint I18N/WPWG discussion today [1] I anticipate that we will not add dir/lang to Payment Request. I believe there is now support for publishing the Recommendation with informative hooks that indicate that internationalization for these two strings needs to be fixed and that we are part of a Web community discussion about how to do that with a platform-wide solution. I took an action to work with @r12a on text for the specification.

[1] https://www.w3.org/2021/10/26-wpwg-minutes.html#t03

ianbjacobs commented 2 years ago

@r12a and @aphillips, I have updated this pull request based on the 26 Oct joint discussion. Per @r12a's comments during the meeting, I have characterized this as (1) a fix and (2) pending progress on the platform wide solution. I welcome your review of this and any suggestions.

ianbjacobs commented 2 years ago

@aphillips, many thanks to you and the I18N Working Group for working with us on this and other issues. We really do appreciate the engagement.