search

w3c / payment-request

Payment Request API
https://www.w3.org/TR/payment-request-1.1/
Other
482 stars 183 forks source link

passing data on complete() #982

Closed marcoscaceres closed 1 year ago

marcoscaceres commented 2 years ago

closes #981

The following tasks have been completed:

Implementation commitment:

Optional, impact on Payment Handler spec?

Preview | Diff

marcoscaceres commented 2 years ago

@dcrousso, ok... we now do IDL conversion and member validation early, giving the developer an opportunity to recover. And the [[\complete]] = true now happens after the checks.

marcoscaceres commented 1 year ago

@stephenmcgruer, @rsolomakhin, would appreciate your review on this addition?

rsolomakhin commented 1 year ago

Is there a link to the WebKit issue available?

stephenmcgruer commented 1 year ago

Is there a link to the WebKit issue available?

I found https://bugs.webkit.org/show_bug.cgi?id=235415 and https://github.com/WebKit/WebKit/commit/2fbfd75778b823914bef59e83d4fb9dc4ddc95e4, but looks like the 'real' issue is an internal Apple one (which is of course ok :))

marcoscaceres commented 1 year ago

Yeah, this just adds optional proprietary behavior for completing.

marcoscaceres commented 1 year ago

Thanks @stephenmcgruer! I agree with you about "an IDL value of the type specified by the specification". If eventually we have a spec to link to, will definitely update.

Updating the WPT tests would be great!

We should get some tests for free from WPT once we merge (at least for the method signature length).

I'm not sure it's worth adding a manual test, but can add one if you think it's worth it.

stephenmcgruer commented 1 year ago

We should get some tests for free from WPT once we merge (at least for the method signature length).

Of course, I completely forgot about idlharness tests >_<. (Which I really shouldn't, given my history in WPT!). I think that is sufficient for this use-case, thanks :)