search

w3c / performance-timeline

Performance Timeline
https://w3c.github.io/performance-timeline/
Other
111 stars 27 forks source link

More fixes #137

Closed plehegar closed 5 years ago

plehegar commented 5 years ago

Fixes a bug introduced in https://github.com/w3c/performance-timeline/pull/135/commits/200e82b12b30380e6fce521755982174e66f7df3

and in https://github.com/w3c/performance-timeline/pull/127/commits/f13c0304485d0c3b7ce48223b0dcdd2695c6c0b4

Preview | Diff

npm1 commented 5 years ago

@plehegar I think you need to revert f13c0304485d0c3b7ce48223b0dcdd2695c6c0b4. gh-pages should be pointing at the L3 version whereas level2 is the 'republished' level 2 version. gh-pages should have the buffered flag and level2 should not.

npm1 commented 5 years ago

And also I don't see any reviewer for that commit which is 401 lines?

npm1 commented 5 years ago

Ugh GitHub is so confusing... Looks like that commit is just a rebase and the real problem was 4029b1d54d3e0dd4799ef8407b96ed9b96469567. It should be reverted.

plehegar commented 5 years ago

ok. I'll revert the changes. Apologizes for messing this one up. :(

yoavweiss commented 5 years ago

The buffered flag was restored on gh-pages. Should we abandon this PR?