w3c / performance-timeline

Performance Timeline
https://w3c.github.io/performance-timeline/
Other
111 stars 27 forks source link

Check shouldAdd when appending to buffer #173

Closed npm1 closed 4 years ago

npm1 commented 4 years ago

This PR renames the determine eligibility algorithm to a name that more clearly indicates the check done internally (checks whether the buffer is full). It also adds the shouldAdd check to right before adding the entry to the performance entry buffer, as this is now possible after https://github.com/w3c/timing-entrytypes-registry/pull/15. This is being done to allow Event Timing to only buffer entries of duration at least 104.


Preview | Diff