search

w3c / picture-in-picture

Picture-in-Picture (PiP)
https://w3c.github.io/picture-in-picture
Other
311 stars 39 forks source link

Treat DocumentOrShadowRoot as an interface mixin #114

Closed foolip closed 5 years ago

foolip commented 5 years ago

Matching https://dom.spec.whatwg.org/#mixin-documentorshadowroot.

Preview | Diff

beaufortfrancois commented 5 years ago

Thanks @foolip!

Even though it is not supported in Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=781257), do you suggest I add it to the spec? How about Web Platform Tests? Are they going to complain?

foolip commented 5 years ago

Partial interfaces, the old [NoInterfaceObject] + A implements B pattern and the new interface mixin + A includes B pattern and are just a spec writing convenience, doing exactly the same thing as if everything was defined in a single interface definition.

So no tests of behavior would be affected by this. idlharness.js tests already handle mixins. After the spec is updated, a PR against wpt will be automatically be created, I'll try to remember to mention you there so you can see how it works.

beaufortfrancois commented 5 years ago

I'll be monitoring these changes. Thanks!

FYI @mounirlamouri

foolip commented 5 years ago

The change reached wpt in https://github.com/web-platform-tests/wpt/pull/14990.