search

w3c / picture-in-picture

Picture-in-Picture (PiP)
https://w3c.github.io/picture-in-picture
Other
311 stars 39 forks source link

BikeShed nits #148

Closed marcoscaceres closed 4 years ago

marcoscaceres commented 5 years ago

Just a small thing... when talking about content attributes VS IDL attributes, make sure you use this syntax for content attributes:

<{element/attribute}>

So:

<{video/disablePictureInPicture}>
marcoscaceres commented 5 years ago

More details here: https://tabatkins.github.io/bikeshed/#autolink-wrappers

beaufortfrancois commented 4 years ago

@marcoscaceres As I'm always referring to IDL attributes, I guess we're good right?

marcoscaceres commented 4 years ago

Yep, if that's the case, then sure...

marcoscaceres commented 4 years ago

Actually, this doesn't appear to be true...

beaufortfrancois commented 4 years ago

Fixed with https://github.com/w3c/picture-in-picture/pull/187