search

w3c / picture-in-picture

Picture-in-Picture (PiP)
https://w3c.github.io/picture-in-picture
Other
311 stars 39 forks source link

Integration with HTML #156

Closed marcoscaceres closed 4 years ago

marcoscaceres commented 5 years ago

In #150, @domenic wrote the following. Creating an issue so it doesn't get lost.

Note that (if it has multi-implementer interest) the https://wicg.github.io/picture-in-picture/#htmlvideoelement-extensions section should migrate to the HTML Standard, linking to the algorithms defined in this separate specification. This would also allow the chance to fix several issues with the current specification due to insufficient integration (e.g. the use of EventHandler attributes on HTMLMediaElement instead of GlobalEventHandlers, or the way that autoPictureInPicture, disablePictureInPicture, onenterpictureinpicture, andonleavepictureinpicture have no definitions).

beaufortfrancois commented 4 years ago

@mounirlamouri As we're thinking about Candidate Recommendation, what shall we do with this issue?

marcoscaceres commented 4 years ago

Not that I'm participating, but I'd highly encourage you to do this integration. You get a ton of stuff for free when you integrate with HTML, plus you get awesome feedback from the HTML editors.

marcoscaceres commented 4 years ago

(and you potentially reduce a bunch of spec duplication)

beaufortfrancois commented 4 years ago

@marcoscaceres I'm gonna re-open this one as I think you meant closing #148 when submitting https://github.com/w3c/picture-in-picture/pull/187

marcoscaceres commented 4 years ago

oh, yes, sorry about that!

mounirlamouri commented 4 years ago

Adding to the agenda to discuss whether the group thinks we should merge middle-size specifications like Picture-in-Picture to the HTML specification. The group agreed to move Media Playback Quality that's definitely short and it seems likely we wouldn't move large specification like MSE or EME. Where do we draw the line?

marcoscaceres commented 4 years ago

Note, this isn't about merging the spec back into HTML: it's about a "fair division of labor" between the two specs. I don't think the HTML folks want to maintain that picture-in-picture specific details, but anything related to HTMLVideoElement should really go into HTML... and HTML pointing back to this spec as needed (as per the OP).

mounirlamouri commented 4 years ago

I understand but if we start splitting away extensions to HTMLVideoElement from this spec, we are going to have a spaghetti specification where half of it is in the HTML spec and half in the Picture-in-Picture spec.

marcoscaceres commented 4 years ago

This spec already depends on all the following things defined in other specs (image below)... the thing I guess to weigh up is if anyone else would also benefit from the extensions being made to HTMLVideoElement.

Screen Shot 2020-06-17 at 9 25 05 am

chrisn commented 4 years ago

I seems to me that it's preferable for maintenance that the spec is kept in one place, so +1 to @mounirlamouri's comment above.

tidoust commented 4 years ago

Discussed during 11 August 2020 call. Two resolutions taken by the group:

RESOLUTION: Keep the Picture-in-Picture specification as-is as it doesn't extend the HTML specification apart from partial interface RESOLUTION: Write best practices with regards to media specifications and HTML extension

mounirlamouri commented 4 years ago

I opened https://github.com/w3c/media-wg/issues/20 for the best practices. I will close this issue.