search

w3c / picture-in-picture

Picture-in-Picture (PiP)
https://w3c.github.io/picture-in-picture
Other
311 stars 39 forks source link

PR Preview broken #159

Closed beaufortfrancois closed 5 years ago

beaufortfrancois commented 5 years ago

@tidoust Can you reconfigure PR Preview at https://github.com/w3c/picture-in-picture/settings/installations? We've lost it when migrating to W3C org.

tidoust commented 5 years ago

What exactly is broken? PR Preview is already in the list of Installed GitHub Apps and should work out of the box.

beaufortfrancois commented 5 years ago

I believe it should have appended the usual Preview | Diff text after @dontcallmedom message at https://github.com/w3c/picture-in-picture/pull/158 but it didn't.

beaufortfrancois commented 5 years ago

Oh! Maybe not since it monitors index.bs file. See https://github.com/w3c/picture-in-picture/blob/master/.pr-preview.json

tidoust commented 5 years ago

Yes, for instance, #153 that you created before the transfer does not have a "PR preview" link (and shouldn't).