Closed a2sheppy closed 5 years ago
Looking at https://cs.chromium.org/search/?q=f:expected+f:global+f:txt+f:webexposed+%22setter+disable%22+f:stable&sq=package:chromium&type=cs, it seems like disabled
was used to disable the HTML element completely. I can't find an attribute that ends with "disabled".
For info, we've picked disablePictureInPicture
because of a similar disableRemotePlayback
attribute.
WDYT @mounirlamouri?
I wouldn't mind much between one or the other if we didn't already ship in Chrome. With one implementation out there, and with remote playback precedent, it seems worth keeping the current name IMO.
On Mon, 12 Aug 2019, 04:42 François Beaufort, notifications@github.com wrote:
Looking at https://cs.chromium.org/search/?q=f:expected+f:global+f:txt+f:webexposed+%22setter+disable%22+f:stable&sq=package:chromium&type=cs, it seems like disabled was used to disable the HTML element completely. I can't find an attribute that ends with "disabled".
For info, we've picked disablePictureInPicture because of a similar disableRemotePlayback attribute.
WDYT @mounirlamouri https://github.com/mounirlamouri?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/w3c/picture-in-picture/issues/160?email_source=notifications&email_token=AAEMBFSVAM2QWL4PNABZYSLQEFECTA5CNFSM4ILAKCM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4CIVHI#issuecomment-520391325, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEMBFUHJSVYJU4GYVJVNZLQEFECTANCNFSM4ILAKCMQ .
You're right then. Leave it as is. I say to drop this.
HTML tends to use the past-tense verb "disabled" in names for Boolean attributes (such as
<input>
'sdisabled
attribute), rather than the imperative "disable". Consider renamingdisablePictureInPicture
topictureInPictureDisabled
to align with this.