leavepictureinpicture event fires with Picture-in-Picture window

w3c / picture-in-picture

Picture-in-Picture (PiP)

https://w3c.github.io/picture-in-picture

Other

311 stars 42 forks source link

leavepictureinpicture event fires with Picture-in-Picture window #189

Closed beaufortfrancois closed 4 years ago

beaufortfrancois commented 4 years ago

FIX https://github.com/w3c/picture-in-picture/issues/188

beaufortfrancois commented 4 years ago

Web platform tests changes are also available in https://chromium-review.googlesource.com/c/chromium/src/+/2241537

foolip commented 3 years ago

I have filed https://bugs.webkit.org/show_bug.cgi?id=221083 about renaming EnterPictureInPictureEvent to PictureInPictureEvent. It turns out this shipped in Safari 13.1, and probably nobody noticed the rename in the spec.

When making changes like this, it would be great to file issues for all engines that are affected. (Source/WebCore/Modules/pictureinpicture/EnterPictureInPictureEvent.idl was in WebKit at the time this issue was filed.)