w3c / picture-in-picture

Picture-in-Picture (PiP)
https://w3c.github.io/picture-in-picture
Other
310 stars 39 forks source link

Remove autoPictureInPicture HTMLVideoElement attribute #216

Closed beaufortfrancois closed 1 year ago

beaufortfrancois commented 1 year ago

This PR is about removing the autoPictureInPicture HTMLVideoElement attribute from the spec. The only browser that implemented it for experimental purposes was Chrome and it never shipped.

@steimelchrome PTAL


Preview | Diff

steimelchrome commented 1 year ago

Changes lgtm but looks like the build was unsuccessful

beaufortfrancois commented 1 year ago

FYI @chrisn @jernoble

chrisn commented 1 year ago

caniuse says autoPictureInPictureElement is implemented in Safari, so want to confirm with @jernoble.

beaufortfrancois commented 1 year ago

autoPictureInPicture is in WebKit but doesn't actually do anything. See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

Same applies to disablePictureInPicture: https://github.com/search?q=repo%3AWebKit%2FWebKit+disablePictureInPicture&type=code

chrisn commented 1 year ago

Thanks!