search

w3c / picture-in-picture

Picture-in-Picture (PiP)
https://w3c.github.io/picture-in-picture
Other
310 stars 39 forks source link

Replace return with resolve #227

Closed beaufortfrancois closed 1 month ago

beaufortfrancois commented 3 months ago

FIX https://github.com/w3c/picture-in-picture/issues/226

Preview | Diff

joeyparrish commented 3 months ago

Thanks @beaufortfrancois for addressing this!

beaufortfrancois commented 1 month ago

What shall we do about this PR? It seems like updating the spec with suggested changes from @marcoscaceres would make current implementations not compliant.

beaufortfrancois commented 1 month ago

If that's okay with everyone, I'll merge this PR and will open an issue about @marcoscaceres's feedback

beaufortfrancois commented 1 month ago

I've opened https://github.com/w3c/picture-in-picture/issues/229