w3c / presentation-api

Presentation API
https://www.w3.org/TR/presentation-api/
Other
71 stars 39 forks source link

typo remove method #508

Closed youkinjoh closed 1 year ago

youkinjoh commented 1 year ago

This logic is remove method when reconnect.

Target method name is onclose .

    connection.onclose = _ => {
      connection = null;
      showDisconnectedUI();
    };

But, this logic remove onclosed method.

    // Disconnect from existing presentation, if not attempting to reconnect
    if (connection && connection != newConnection && connection.state != 'closed') {
      connection.onclosed = undefined;
      connection.close();
    }

Preview | Diff

w3cbot commented 1 year ago

tidoust marked as non substantive for IPR from ash-nazg.

anssiko commented 1 year ago

@youkinjoh thank you for your attention to detail!

anssiko commented 1 year ago

(It looks like the CI failure is unrelated, trying to merge.)