search

w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
146 stars 40 forks source link

Expose options #187

Closed martinthomson closed 8 years ago

martinthomson commented 8 years ago

This one builds on #182 to also address #183 and #184.

@kitcambridge, does this address your concerns?

ghost commented 8 years ago

Yes, LGTM. Thank you!

beverloo commented 8 years ago

Thanks!

@mvano PTAL?

mvano commented 8 years ago

Looks good, @martinthomson could you please address @beverloo's comments? After that this is fine to merge. Thanks!

martinthomson commented 8 years ago

@mvano, updated, thanks.