search

w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
145 stars 40 forks source link

Fix a series of warnings in the specification #253

Closed beverloo closed 7 years ago

beverloo commented 7 years ago

What remains are nine warnings about missing definitions in the *Init dictionaries, which would be either duplicate or refer to the definitions of the identically named properties in the interfaces.

I don't think it's a fantastic idea to do either. @marcoscaceres would you know what the idiomatic way of dealing with those warnings is? A few examples:

beverloo commented 7 years ago

That question basically is #232 by the way, given your comment on https://github.com/w3c/push-api/pull/231#issuecomment-265552037. Happy to make the change of course.

marcoscaceres commented 7 years ago

I'm on vacation till next week. If it's ok, will take a look then. However, you can see "best practice"(tm) in the Payment Request spec.

On 22 Apr 2017, at 4:17 am, Peter Beverloo notifications@github.com wrote:

That question basically is #232 by the way, given your comment on #231 (comment). Happy to make the change of course.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

beverloo commented 7 years ago

Cool, thanks! I'll take a look at the Payment Request specification to see how they solve this. The rest of the changes in this PR are editorial, so I'll go forward and submit this.