w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
145 stars 40 forks source link

Clarify that applicationServerKey can be required by implementations? #279

Closed beverloo closed 7 years ago

beverloo commented 7 years ago

Chrome requires developers to pass an applicationServerKey, Firefox does not. The specification considers it optional. Should we add a non-normative note about some implementations requiring this?

martinthomson commented 7 years ago

We didn't really consider the possibility (or at least I didn't) that it might be mandatory. Since it could be, we need to define what happens if the value isn't there and the browser/push service require it. That's more than a non-normative note.

beverloo commented 7 years ago

Good point, we'd have to upgrade the subscribe() algorithm as well. I guess it would be good for developers to know this prior to subscribing as well, but that could get a bit verbose. Let me send a PR for the subscribe() bits first.