search

w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
145 stars 40 forks source link

Secure contexts #282

Closed annevk closed 7 years ago

annevk commented 7 years ago

Any reason this is not using [SecureContext]? Would be good to add a note explaining why.

beverloo commented 7 years ago

The Push API predates [SecureContext], so it's just an oversight.

I see that ServiceWorkerRegistration is also marked as [SecureContext], which is a dependency. Neither Chromium's nor Firefox' implementations have been updated, so I wonder if they think it's safe to apply the change?

Semantically this should be [SecureContext], we just have to make sure it's Web compatible. I'll figure out if we have a way of measuring this.

/cc @mattto @jakearchibald

beverloo commented 7 years ago

I filed https://github.com/heycam/webidl/issues/420 to figure out whether we should also specify this on the interfaces already limited to Service Workers, and thereby secure contexts. It's harmless to add those for now in either case.