search

w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
144 stars 40 forks source link

Switch to EpochTimeStamp #338

Closed marcoscaceres closed 2 years ago

marcoscaceres commented 2 years ago

Closes #337

DOMTimeStamp is giong away: whatwg/webidl#1021

It was renamed EpochTimeStamp and is now part of HR-Time: w3c/hr-time#124

The following tasks have been completed:

Implementation commitment:

Preview | Diff

martinthomson commented 2 years ago

So DOMTimeStamp is nicely linked to the WebIDL spec. That means we don't really have to have a definition for it in this specification. I can't find a similar resource for EpochTimeStamp. Is this something that respec will sort out for us?

marcoscaceres commented 2 years ago

Sorry, I should have given more context!

So DOMTimeStamp is nicely linked to the WebIDL spec.

DOMTimeStamp is giong away: https://github.com/whatwg/webidl/pull/1021

That means we don't really have to have a definition for it in this specification.

It was renamed EpochTimeStamp (because refactoring code, yay!!) and is now part of HR-Time: https://github.com/w3c/hr-time/pull/124

I can't find a similar resource for EpochTimeStamp. Is this something that respec will sort out for us?

Missing reference... fixing now :)

marcoscaceres commented 2 years ago

Implemented .expirationTime it in Gecko (it doesn't do much right now, as I'm unsure if the Mozilla push service provides one, but it could be useful)... will send a patch.

Screen Shot 2021-10-11 at 6 33 38 pm

marcoscaceres commented 2 years ago

Using Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1497431 ... sent a patch.

beverloo commented 2 years ago

This is great Marcos, thank you! Looks good to me, and I filed a Chromium bug for us to move here: https://bugs.chromium.org/p/chromium/issues/detail?id=1258800

marcoscaceres commented 2 years ago

@beverloo, just a heads up that I've defaulted expirationTime = null; ... cleans up implementations a little bit, because no need to manually set it to null anymore.