search

w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
144 stars 40 forks source link

Integrate with Permission spec #341

Closed marcoscaceres closed 2 years ago

marcoscaceres commented 2 years ago

Closes #333 Closes #322

Defers to permission spec to handle permission request and use Permission spec's PermissionState enum instead (it has the same values).

I'm borrowing (ok, stealing👹) the nice definition of "express permission" and moving it to the Permission Spec, so we can use it more widely. Is that ok?

@beverloo, @martinthomson: I need to double-check, but asking for permission from the service worker doesn't seem like it should be possible. We should always say "denied".

The following tasks have been completed:

Implementation commitment:

Preview | Diff

marcoscaceres commented 2 years ago

Linking to #322 too... Re: service worker always returning denied.

marcoscaceres commented 2 years ago

Filed Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1737746 and sent patch.

@miketaylr, could you help me with filing the Chromium bug + patch?

miketaylr commented 2 years ago

@miketaylr, could you help me with filing the Chromium bug + patch?

Yep, sure thing. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1263499