w3c / push-api

Push API
https://w3c.github.io/push-api/
Other
144 stars 40 forks source link

Rewrite .subscribe() to fix various bugs #350

Closed marcoscaceres closed 2 years ago

marcoscaceres commented 2 years ago

The following are not testable/observable, but spec bugs nonetheless:


Preview | Diff

marcoscaceres commented 2 years ago

Our implementation runs one of the steps out of order: the userVisibleOnly requirement is only checked quite a late in the process, as there may be (toady hypothetical) cases in which we don't require it, e.g. for extensions.

Ok, I'll move that to async part and just add a note. The ordering when that happens doesn't matter too much.