Give PushMessageData a clear internal concept to hold the bytes and also make it clear that it cannot be null. None of the methods were prepared to handle it being null and nothing ever creates a PushMessageData object where it is null.
Partially addresses the concerns in #380 and fixes #381.
I installed tidy-html5 but that appears to not work. There are no instructions provided by this repository as to how to do formatting so I guess I'm fine with that happening in an automatic follow-up cleanup commit...
One thing that I'm not familiar with is ReSpec and how it does linking so that probably needs careful review here as I'm trying to introduce some new links.
Give PushMessageData a clear internal concept to hold the bytes and also make it clear that it cannot be null. None of the methods were prepared to handle it being null and nothing ever creates a PushMessageData object where it is null.
Partially addresses the concerns in #380 and fixes #381.
I installed tidy-html5 but that appears to not work. There are no instructions provided by this repository as to how to do formatting so I guess I'm fine with that happening in an automatic follow-up cleanup commit...
One thing that I'm not familiar with is ReSpec and how it does linking so that probably needs careful review here as I'm trying to introduce some new links.
Preview | Diff