Closed domel closed 11 months ago
If the SVG files have editable references, it would be good to put comments in place pointing to them, in case anything needs to be changed in the future.
@gkellogg What do you mean by "editable references"? Do you want to add (XML) comments in SVG files?
If you look at https://github.com/w3c/rdf-semantics/issues/42#issuecomment-1712579511 you’ll see an inline XML-style comment “Source for this image may be found …” in the code snippet. That’s what I was referring to.
@gkellogg Oh yes. I didn't add it on purpose. Experienced by other PRs and @pfps comments, I preferred not to change to much the HTML structure. If there is consent to this change, I will be happy to add <figure>
, even in the last image, it is worth adding <picture>
.
There are some accessibility requirements for figures, but I think they mostly describe more explicit RDF statements. alt
, and aria-describedby
attributes are probably appropriate, but they don't necessarily need to be wrapped in a figure.
My point was that, in the case of RDF Concepts, figure 2 includes the following comment:
<!-- Source for this file is at https://docs.google.com/drawings/d/1I_QxbUgnQXumXzb8c0WNJHIQ-mtRs2S80dDG6i9aOD8 -->
This allows someone to go to that URL and re-edit the figure to be able to export an update SVG if it ever becomes necessary. This can be put anywhere near the image.
But I did the pictures locally in my computer so I guess that it can only link to the github repo.
If you did the pictures locally using some format other than SVG, it might be worth adding the source for these drawings to the repository with some README that indicated any software used to process them. Of course, if you created them by hand, then they can probably be edited by hand in the future.
Yes, I created them by hand. I used the well-known Inkscape. The default format is SVG.
Cool, I think putting something about how the images are authored in a README would be useful. Trying to edit them by hand would be beyond me.
@gkellogg Done
example6.jpg
that wasn't used in HTMLSee https://github.com/w3c/rdf-semantics/issues/42
Preview | Diff