search

w3c / rdf-star

RDF-star specification
https://w3c.github.io/rdf-star/
Other
119 stars 23 forks source link

Basic SPARQL-star eval tests #114

Closed afs closed 3 years ago

afs commented 3 years ago

SPARQL-star eval tests.

This is a snapshot of work-in-progress.

gkellogg commented 3 years ago

We should add "eval/manifest.jsonld" to "sparql/manifest.jsonld" and decide if "manifest-query.jsonld" and "manifest-update.jsonld" still belong.

afs commented 3 years ago

@gkellogg Yes (already done locally).

I'm only producing one manifests at the moment because it keeps changing; I'd like some advice on making JSON-LD for eval tests look nice when the suite is moderately stable.

gkellogg commented 3 years ago

There’s a make task to do it, but it just uses a standard JSON serializer. Otherwise, you could write a customized one to control white space, but I think trying to maintain that may be more trouble than it’s worth.

afs commented 3 years ago

This includes conversion "RDF*" to "RDF-star" in the Turtle and SPARQL test areas, and a general test cleanup, as separate commits.

afs commented 3 years ago

This is ready for implementers to try out:

It covers:

Still more to do:

afs commented 3 years ago

We need a sparql/eval/manifest.jsonld

Yes - this is on the todo list above "Acceptable JSON-LD".

Previous I have crafted a template that makes JSON that uses "tests/manifest-context.jsonld" so is more "JSON" and less "RDF". Could make-jsonld-manifests use that? Currently, it will overwrite the existing files.

I just haven't figured out how to make it work with the SPARQL eval requirements.

(and .html?)

make-html-manifests.py does not work - my guess is that it is because the actions are bnodes of a pair or more triples.

pchampin commented 3 years ago

make-html-manifests.py does not work - my guess is that it is because the actions are bnodes of a pair or more triples.

that's correct. I need to fix it...

afs commented 3 years ago

I just haven't had time so it was either delay and remain in draft or put it for review now. The status is written in the comment above.

It going to cover several areas. I thought it was more useful to have this first part now.

gkellogg commented 3 years ago

Looks good, they're all passing for me now.

We need to make sure the grammar is updated to add EmbTP (or whatever it's called now) to PrimaryExpression.

hartig commented 3 years ago

We need to make sure the grammar is updated to add EmbTP (or whatever it's called now) to PrimaryExpression.

It's on my agenda to work on the PR for that.

afs commented 3 years ago

Rebased to current main.