w3c / rdf-star

RDF-star specification
https://w3c.github.io/rdf-star/
Other
119 stars 23 forks source link

Implementation reports #131

Closed gkellogg closed 3 years ago

gkellogg commented 3 years ago

Just Ruby implementations for right now.


Preview | Diff

afs commented 3 years ago

Would it be possible to split this into one for the EARL report generator machinery and one for each report?

I am assuming the overall workflow long-term is that implementers, or a proxy helping them, adds an implementation as a PR that is just about one system. We then have a record of who-what-when. It would be nice if the first reports show how it is done.

afs commented 3 years ago

What's manifests.nt? I don't think it should be in the checked-in files?

If it is needed, can it be a Turtle file with prefixes so it is a little more viewable?


Answer my own question: intermediate file, does not need to be in the git repo.

afs commented 3 years ago

Great system!

I tried out the instructions in the README but the cd is breaking things:

 >>  rm -f manifests.nt && (cd ..; rake reports/manifests.nt)
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)

I guessed and parsed all the TTL files into one NT file. Then:

earl-report: command not found

Need to note that .../gems/bin is on the path.

There is an implicit assumption about use of <https://w3c.github.io/rdf-star/> -- see comment about making manifest absolute and not depend on an external URI. https://github.com/w3c/rdf-star/pull/130#discussion_r595936487

gkellogg commented 3 years ago

Would it be possible to split this into one for the EARL report generator machinery and one for each report?

I am assuming the overall workflow long-term is that implementers, or a proxy helping them, adds an implementation as a PR that is just about one system. We then have a record of who-what-when. It would be nice if the first reports show how it is done.

Sure, I can do that. Note that I usually need to tweak the reports to deal with minor, but typical, issues. I may need to be added as a committer to the repo to be able to update such PRs.

What's manifests.nt? I don't think it should be in the checked-in files?

If it is needed, can it be a Turtle file with prefixes so it is a little more viewable?

I can actually update the .earl file to reference the manifests directly, particularly if BASE is absolute, so we can eliminate this file. I've used it, for example in JSON-LD, to simplify the workflow.

earl-report: command not found

Need to note that .../gems/bin is on the path.

There is an implicit assumption about use of <https://w3c.github.io/rdf-star/> -- see comment about making manifest absolute and not depend on an external URI. #130 (comment)

Yes, and with the addition of a Gemfile in PR #130, I'll update the instructions to bundle install; bundle exec rake

pchampin commented 3 years ago

Sure, I can do that. Note that I usually need to tweak the reports to deal with minor, but typical, issues. I may need to be added as a committer to the repo to be able to update such PRs.

Sure. Done.

gkellogg commented 3 years ago

Other todo:

pchampin commented 3 years ago

This was discussed during today's call: https://w3c.github.io/rdf-star/Minutes/2021-03-19.html#t03

gkellogg commented 3 years ago

Replaced by #137.