search

w3c / rdf-star

RDF-star specification
https://w3c.github.io/rdf-star/
Other
120 stars 23 forks source link

Fix links #190

Closed afs closed 3 years ago

afs commented 3 years ago

Preview | Diff

afs commented 3 years ago

Fixing reSpec workflow links.

There may be some noise on this PR - it's the only way I have to test the changes. When ready, I'll switch from "draft" to "ready to review".

afs commented 3 years ago

Fixed some links but not all

Fixed:

    page not found from editors_draft.html to combining-rdf-star-graphs
    anchor not found from editors_draft.html to N-TRIPLES#grammar-production-triple
    anchor not found from editors_draft.html to rdf-sparql-XMLres#results

but not the errors:

    page not found from editors_draft.html to ../tests/index.html
    page not found from editors_draft.html to ../UCR/rdf-star-ucr.html#annotate-statements-from-other-named-graphs-and-datasets
    page not found from editors_draft.html to ../UCR/rdf-star-ucr.html#annotate-commit-deltas
    page not found from editors_draft.html to ../UCR/rdf-star-ucr.html#meta-properties-over-properties

Using /UCR/... etc changes the errors to 

    page not found from editors_draft.html to UCR/rdf-star-ucr.html#

note - no "/".

gkellogg commented 3 years ago

I reported a bug against w3c/spec-prod action. This seems to be a problem, with link-checker, probably because it doesn’t use a local,server, and can’t load local references.

https://github.com/w3c/spec-prod/issues/86

afs commented 3 years ago

After the mention on Friday, I didn't try much out on the "../" - good to know it has reported.

The fixed ones are actual errors - I just don't understand why they have appeared now when as far as I can see they aren't new. The fixes do work for them at least.

gkellogg commented 3 years ago

After the mention on Friday, I didn't try much out on the "../" - good to know it has reported.

The fixed ones are actual errors - I just don't understand why they have appeared now when as far as I can see they aren't new. The fixes do work for them at least.

This probably duplicates some fixes I made in #188. The link checker does, indeed, find real problems, which is good; it just doesn't handle relative links properly, which also affects the N3 spec, as well as many others.